[Asterisk-code-review] app_queue: option to start the periodic announcements at a different... (asterisk[master])

[Jaco Kroon]

Attention is currently required from: N A.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19899 )

Change subject: app_queue:  option to start the periodic announcements at a different time interval than the frequency.
......................................................................


Patch Set 2:

(4 comments)

Patchset:

PS2: 
Does this look better?


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/e666419e_e37b7b2b 
PS1, Line 3428: 		q->periodicannouncestartdelay = atoi(val);
> This value should be initialized to 0 explicitly in init_queue
-1 is a better value than 0 for the simple reason that by default we should maintain backwards compatibility/behaviour.


https://gerrit.asterisk.org/c/asterisk/+/19899/comment/f3772eb2_590fbddc 
PS1, Line 8528: 	if (qe.parent->periodicannouncestartdelay >= 0) {
> should this be > 0, not >= 0? Otherwise we're just adding 0 with the first statement.
Which is correct, so 0 seconds into the wait just means immediately play the periodic announcement on joining the queue.  Because we back-step periodicannouncefrequency on the last time played this will have the desired effect.  This is actually what our client specifically requested "first thing when queued".  After internal deliberation we just realized it may make sense to play a "heavy call volumes" kind of message at say 30 seconds, and then only play it every 120s after that.


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/6a9b135d_66527ffc 
PS1, Line 283: ; may not always be desired.
> Is there a default value that should be specified here?
I figured "normally" implies "if unset".  I believe the rewording should make this more clear?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19899
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia79984b6377ef78f167ad9ea2ac084bec29955d0
Gerrit-Change-Number: 19899
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 23 Feb 2023 07:36:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230223/e0c37d02/attachment-0001.html>