[Asterisk-code-review] app_read: add option to return terminator on empty digits (asterisk[18])

[N A]

Attention is currently required from: Michael Bradeen, Benjamin Keith Ford.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19883 )

Change subject: app_read: add option to return terminator on empty digits
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/19883/comment/24504298_10148edc 
PS2, Line 135: 	OPT_NOEMPTY = (1 << 4),
> Is there another name that could be used here that might be a bit more descriptive of what's going o […]
How about OPT_KEEP_TERMINATOR or something along those lines?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5
Gerrit-Change-Number: 19883
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 13:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230217/1acc0f33/attachment.html>