[Asterisk-code-review] res_pjsip: Upgraded bundled pjsip to 2.13 (asterisk[20])

[Michael Bradeen]

Attention is currently required from: Michael Bradeen.

Hello George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19890

to look at the new patch set (#2).

Change subject: res_pjsip: Upgraded bundled pjsip to 2.13
......................................................................

res_pjsip: Upgraded bundled pjsip to 2.13

Removed multiple patches.

Code chages in res_pjsip_pubsub due to changes in evsub.

Pjsip now calls on_evsub_state() before on_rx_refresh(),
so the sub tree deletion that used to take place in
on_evsub_state() now must take place in on_rx_refresh().

Additionally, pjsip now requires that you send the NOTIFY
from within on_rx_refresh(), otherwise it will assert
when going to send the 200 OK. The idea is that it will
look for this NOTIFY and cache it until after sending the
response in order to deal with the self-imposed message
mis-order. Asterisk previously dealt with this by pushing
the NOTIFY in on_rx_refresh(), but pjsip now forces us
to use it's method.

Changes were required to configure in order to detect
which way pjsip handles this as the two are not
compatible for the reasons mentioned above.

A corresponding change in testsuite is required in order
to deal with the small interal timing changes caused by
moving the NOTIFY send.

ASTERISK-30325

Change-Id: I50b00cac89d950d3511d7b250a1c641965d9fe7f
---
M configure
M configure.ac
M include/asterisk/autoconfig.h.in
M menuselect/autoconfig.h.in
M menuselect/configure
M res/res_pjsip_pubsub.c
M third-party/pjproject/configure.m4
M third-party/pjproject/patches/0000-remove-third-party.patch
D third-party/pjproject/patches/0100-allow_multiple_auth_headers.patch
D third-party/pjproject/patches/0200-potential-buffer-overflow-in-pjlib-scanner-and-pjmedia.patch
D third-party/pjproject/patches/0201-potential-stack-buffer-overflow-when-parsing-message-as-a-STUN-client.patch
D third-party/pjproject/pjproject-2.12.1.tar.bz2.md5
A third-party/pjproject/pjproject-2.13.tar.bz2.md5
M third-party/versions.mak
14 files changed, 9,743 insertions(+), 12,522 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/90/19890/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19890
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I50b00cac89d950d3511d7b250a1c641965d9fe7f
Gerrit-Change-Number: 19890
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230207/feaaf018/attachment-0001.html>