[Asterisk-code-review] res_pbx_validate: Add CLI commands to warn of dialplan problems (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.

Hello Joshua Colp, George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/17719

to look at the new patch set (#10).

Change subject: res_pbx_validate: Add CLI commands to warn of dialplan problems
......................................................................

res_pbx_validate: Add CLI commands to warn of dialplan problems

Adds a mechanism for applications to register a validation
callback function which can be used to preemptively validate
registered dialplan application calls and find syntax or usage
problems. While it is impossible to find every possible runtime
problem that could occur, many applications are characterized
by a particular type of issue which can be found in advanced
and can help users by finding these issues before they cause
problems at runtime. These validation callbacks may thus return
some false negatives, but they should not return any false
negatives.

Going forward, any module containing an application can register
a callback function which will be used for the preemptive
validation.

res_pbx_validate is a module which can be used to interact with
these validation callbacks by allowing users to run these scans
from the CLI. In the future, AMI commands or similar functionality
could also be included here without touching the core.

Additionally, some validation functions are added for common
applications, including Goto, GotoIf, GotoIfTime, Gosub,
GosubIf, Background, BackgroundDetect, ControlPlayback,
Playback, Read, and ReadExten.

ASTERISK-29828 #close

Change-Id: Iaf7a2c8a6982ee5adaae7f7aa63e311d0e9106e3
---
M apps/app_controlplayback.c
M apps/app_playback.c
M apps/app_read.c
M apps/app_readexten.c
M apps/app_stack.c
M apps/app_talkdetect.c
M configs/samples/cli_aliases.conf.sample
A doc/CHANGES-staging/pbx-cli.txt
M include/asterisk/module.h
M include/asterisk/pbx.h
M main/pbx.c
M main/pbx_app.c
M main/pbx_builtins.c
A res/res_pbx_validate.c
14 files changed, 910 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/19/17719/10
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17719
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7a2c8a6982ee5adaae7f7aa63e311d0e9106e3
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 10
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230410/411dc4c0/attachment-0001.html>