[Asterisk-code-review] pbx_dundi: Add PJSIP support. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19702 )

Change subject: pbx_dundi: Add PJSIP support.
......................................................................


Patch Set 6:

(1 comment)

File include/asterisk/dundi.h:

https://gerrit.asterisk.org/c/asterisk/+/19702/comment/6f1eba0a_3ec28fea 
PS6, Line 63: 	DUNDI_PROTO_PJSIP = 4,
> It's still used internally when parsing whether the user wants to use PJSIP or SIP for connections,  […]
That still changes the protocol though, reserving 4. If it's an internal implementation detail, it shouldn't alter the underlying protocol.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19702
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2e28e5a5d007bd49e3df113ad567b011103899bf
Gerrit-Change-Number: 19702
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 06 Apr 2023 13:12:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230406/c806728e/attachment.html>