[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

[Niklas Larsson]

Attention is currently required from: Sean Bright, N A, Alexei Gradinari, Stanislav Abramenkov.

Niklas Larsson has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 15:

(4 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/e32a0985_16223ad3 
PS14, Line 1628: static int realtime_reason_paused = 0;
> `static` storage is initialized to `0` so the explicit initialization is redundant and can be remove […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/beab433c_fa553fd2 
PS14, Line 1628: static int realtime_reason_paused = 0;
> Currently, this is only set to 1 when the module loads. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/6210dc6f_4290f646 
PS14, Line 11740: 		realtime_reason_paused = 0;
> This is initialized twice, which isn't necessary. […]
Done


File doc/CHANGES-staging/app_queue_realtime_reason_paused.txt:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/86017e11_0436a3d4 
PS14, Line 3:  
> The line wrapping splits this word across two lines, wrap this earlier.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 15
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 15:06:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230404/44d553df/attachment.html>