[Asterisk-code-review] audiohook: add directional awareness (asterisk[18])

[Joshua Colp]

Attention is currently required from: Michael Bradeen.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19318 )

Change subject: audiohook: add directional awareness
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_stasis_snoop.c:

https://gerrit.asterisk.org/c/asterisk/+/19318/comment/62680f15_f0b18f8b 
PS1, Line 291: 	audiohook->direction = *direction;
Audiohook should be treated as opaque, and an API call added. As well the API call should only be usable before the audiohook is attached - to prevent audio already flowing in the unintended direction.

There's also code still in res_stasis_snoop to read on the opposite direction in non-both, does that also need to be removed?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19318
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: If8716bad334562a5d812be4eeb2a92e4f3be28eb
Gerrit-Change-Number: 19318
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 09:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220930/90ec9a75/attachment.html>