[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])
Mark Murawski
asteriskteam at digium.com
Mon Sep 26 12:26:26 CDT 2022
Attention is currently required from: Sean Bright, N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )
Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................
Patch Set 15:
(19 comments)
File funcs/func_groupcount.c:
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3b01bee9_7dfb1d85
PS14, Line 795:
> I don't mean what you did above aligning the variable definitions, I mean proper indentation in gene […]
Done
File funcs/func_groupcount.c:
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/f0a41b93_f582bbe1
PS15, Line 792: if (group_or_regex[0] == '/') {
> For example, this should be indented one level from the line above.
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/dc503e82_c1e2755d
PS15, Line 813: else {
> The else should go on the same line as the closing brace above.
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d19f97be_9fd92b15
PS15, Line 818: if (!ast_strlen_zero(category_or_regex)) {
> Same here
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/df0bb59e_1a9f246b
PS15, Line 842: else {
> Same here
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/30fc2e30_d9a67c23
PS15, Line 890: if (group_regex_string) {
> Unindent
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3f291826_407b92cf
PS15, Line 895: if (category_regex_string) {
> This should be unindented one level
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/87061b21_d63f43d2
PS15, Line 908:
> Here is another indentation messup: these 2 lines should be unindented one level. […]
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/83ec7a64_ff1093e1
PS15, Line 922: if (!ast_strlen_zero(group_or_regex)) {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/016d947f_72275484
PS15, Line 944: else {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/adf15321_0505d0f1
PS15, Line 949: if (!ast_strlen_zero(category_or_regex)) {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/772c479d_3b9c8912
PS15, Line 973: else {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3e9d09df_11de8b1a
PS15, Line 1022: if (group_regex_string) {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b560f0b4_2ad26b31
PS15, Line 1027: if (category_regex_string) {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d6b9caeb_dc19672f
PS15, Line 1168: else {
> ditto
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/9af778a7_32441da5
PS15, Line 1394: strncpy(buf, ast_str_buffer(out), len);
> Could we use ast_copy_string instead of strncpy?
Done
File main/app.c:
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/9bf62226_97ec076f
PS15, Line 2490:
> spaces/tabs and alignment
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/4ffa1e30_0f8161dd
PS15, Line 2501:
> You are using spaces here, not tabs
Done
https://gerrit.asterisk.org/c/asterisk/+/17655/comment/f660d74a_640a384d
PS15, Line 2618:
> WHOLE function: spaces/tabs and alginment […]
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 15
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 17:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220926/e5b6a274/attachment.html>
More information about the asterisk-code-review
mailing list