[Asterisk-code-review] sla: Prevent deadlock and crash due to autoservicing. (asterisk[master])

[N A]

Attention is currently required from: George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19308 )

Change subject: sla: Prevent deadlock and crash due to autoservicing.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> Not really a -1 but I wanted to get your attention. […]
To be honest, I really can't at the moment, because ever since the python 3 stuff, I haven't been able to get the test suite working, so I have no way of writing or testing tests. But this is also related to this review, so it's a known mechanism/bug that can happen: https://gerrit.asterisk.org/c/asterisk/+/18564

I have tested it on my end and previously SLA never worked and now it works properly. Given that meetme is going away soon I also wonder if it makes sense to focus test effort on that, given they would probably be removed anyways.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19308
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icc237d50354b5910000d2305901e86d2c87bb9d8
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 16:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220926/6fc994b8/attachment.html>