[Asterisk-code-review] func_frame_trace: Remove bogus assertion. (asterisk[19])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/19174 )

Change subject: func_frame_trace: Remove bogus assertion.
......................................................................

func_frame_trace: Remove bogus assertion.

The FRAME_TRACE function currently asserts if it sees
a MASQUERADE_NOTIFY. However, this is a legitimate thing
that can happen so asserting is inappropriate, as there
are no clear negative ramifications of such a thing. This
is adjusted to be like the other frames to print out
the subclass.

ASTERISK-30210 #close

Change-Id: I8ecbdcf17e35f64bdeab42868471f581ad1d1a56
---
M funcs/func_frame_trace.c
1 file changed, 19 insertions(+), 2 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit




diff --git a/funcs/func_frame_trace.c b/funcs/func_frame_trace.c
index b023c9f..c1f258f 100644
--- a/funcs/func_frame_trace.c
+++ b/funcs/func_frame_trace.c
@@ -341,8 +341,7 @@
 			ast_verbose("SubClass: PVT_CAUSE_CODE\n");
 			break;
 		case AST_CONTROL_MASQUERADE_NOTIFY:
-			/* Should never happen. */
-			ast_assert(0);
+			ast_verbose("SubClass: MASQUERADE_NOTIFY\n");
 			break;
 		case AST_CONTROL_STREAM_TOPOLOGY_REQUEST_CHANGE:
 			ast_verbose("SubClass: STREAM_TOPOLOGY_REQUEST_CHANGE\n");

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19174
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: I8ecbdcf17e35f64bdeab42868471f581ad1d1a56
Gerrit-Change-Number: 19174
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220912/8cb5c338/attachment.html>