[Asterisk-code-review] res_pjsip_outbound_registration: Allow to use multiple proxies for re... (asterisk[16])

[Joshua Colp]

Attention is currently required from: Igor Goncharovsky.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19202 )

Change subject: res_pjsip_outbound_registration: Allow to use multiple proxies for registration
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/19202/comment/c57a37a6_2c53bb7f 
PS1, Line 1407: 	if (!ast_strlen_zero(registration->outbound_proxy)) {
This doesn't need to done at all


https://gerrit.asterisk.org/c/asterisk/+/19202/comment/44a0b973_8f52b55f 
PS1, Line 1409: 		uri = pjsip_parse_uri(pool, tmp.ptr, tmp.slen, 0);
What is the new user behavior if an invalid outbound proxy is specified?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19202
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I064558e66f04b9f3260c46181812a01349761357
Gerrit-Change-Number: 19202
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Sun, 11 Sep 2022 20:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220911/2efcd117/attachment.html>