[Asterisk-code-review] res_pjsip: Add TEL URI support for basic calls. (asterisk[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Joshua Colp, N A, Alexei Gradinari, Benjamin Keith Ford.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18892 )

Change subject: res_pjsip: Add TEL URI support for basic calls.
......................................................................


Patch Set 4:

(2 comments)

File res/res_pjsip_endpoint_identifier_anonymous.c:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/b3c6930a_7c27c12b 
PS4, Line 39: 	ast_copy_pj_str(domain, ast_sip_pjsip_uri_get_hostname(from), domain_size);
> It won't produce invalid URIs, but the lookup will be "anonymous@". […]
Done


File res/res_pjsip_path.c:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/c758b0e3_6a9f1aea 
PS4, Line 53: 	domain_name = ast_alloca(uri_hostname->slen + 1);
> Maybe a URI scheme check is needed?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
Gerrit-Change-Number: 18892
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 15:12:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220907/ad9e20f8/attachment.html>