[Asterisk-code-review] func_export: Add EXPORT function (asterisk[master])

[Mark Murawski]

Attention is currently required from: Sean Bright, N A, Joshua Colp.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15893 )

Change subject: func_export: Add EXPORT function
......................................................................


Patch Set 11:

(1 comment)

File funcs/func_export.c:

https://gerrit.asterisk.org/c/asterisk/+/15893/comment/d18ebe56_b06f6dc7 
PS10, Line 54: 		<note><para>This is a potentially dangerous function if not used carefully, and the MASTER_CHANNEL and SHARED functions
             : 			should be used instead if possible.</para></note>
> I guess that was mostly a holdover, I'm not convinced that it's dangerous at all. That was referencing a potential locking safety issue but there is none. Removed to avoid confusion.

It means... don't mess with other variables at random.  But I think that should be obvious.

Things like DIALSTATUS could be updated using this function and that would obviously change the behavior of the other dialplan running on that channel that expects a proper result from DIALSTATUS.

Really it would be as dangerous as the user wants it to be?  If they want to mess with variables they shouldn't be messing with, then they get to keep both parts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15893
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15893
Gerrit-PatchSet: 11
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:46:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/9848168b/attachment-0001.html>