[Asterisk-code-review] app_multicast: Add Multicast application. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Sep 6 07:30:30 CDT 2022


Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18975 )

Change subject: app_multicast: Add Multicast application.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File apps/app_multicast.c:

https://gerrit.asterisk.org/c/asterisk/+/18975/comment/725448ad_ef0f85c0 
PS1, Line 19:  * \brief Channel audio multicasting
I don't agree with the use of "multicast" for the name of this. Multicast has existing usage both within Asterisk, and also within endpoints. This will cause confusion.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18975
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7ba72f765dbab9b58deeae028baca3f4f8377726
Gerrit-Change-Number: 18975
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 12:30:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/3a865e5a/attachment.html>


More information about the asterisk-code-review mailing list