[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Michael Kuron]

Attention is currently required from: N A, Joshua Colp.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 9:

(1 comment)

File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/17703796_fa844afc 
PS8, Line 969:                 ; (default: no)
> Thanks for clarifying. […]
Correct, it allows chan_pjsip to send out AOC-S messages (which chan_sip did not do), but there is currently no way to send AOC-S messages via AMI. Effectively you can only get the from a PRI channel right now. Support for generating them internally could be added to manager.c, but I don't know if that really needs to be part of this patch or if it could be follow-up work later on.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 22:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Michael Kuron <m.kuron at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221031/45fdc172/attachment.html>