[Asterisk-code-review] translate.c: Prefer better codecs upon translate ties. (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Kevin Harwell.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Prefer better codecs upon translate ties.
......................................................................


Patch Set 6: Code-Review-1

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/adfb3f0f_8a84af87 
PS6, Line 15: ceteris paribus
Can you _translate_ this 😊
j/k.


Patchset:

PS6: 
Couldn't we just create a macro that returns "quality" as a function of sample rate, sample size and maybe default sample interval rather than making arbitrary assignments?


File main/codec_builtin.c:

https://gerrit.asterisk.org/c/asterisk/+/15953/comment/2d281fbf_8aeaaea9 
PS6, Line 300: 	.quality = 100, /* On par with ulaw */
Given that slin is 16 bit shouldn't this be higher than ulaw?


https://gerrit.asterisk.org/c/asterisk/+/15953/comment/82ccb61e_751088af 
PS6, Line 316: 	.quality = 100,
Given that the sample rate > 8000 and it's 16 bit shouldn't ALL the SLINs be higher than ulaw?


https://gerrit.asterisk.org/c/asterisk/+/15953/comment/6ae6ca37_914f6dd1 
PS6, Line 623: 	.quality = 40,
16KHz and only 40?


https://gerrit.asterisk.org/c/asterisk/+/15953/comment/9cbda462_9b6a6902 
PS6, Line 889: 	.samples_count = silk_samples,
Why do the silks not have quality?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 13:31:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221031/4f9ff181/attachment.html>