[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[master])

[Michael Kuron]

Attention is currently required from: Joshua Colp.

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19460 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 3:

(3 comments)

Patchset:

PS3: 
n


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/49f3f9b7_66e6fb1d 
PS2, Line 1834: 	case AST_CONTROL_AOC:
I am using a framehook now and it works fine, but I get these warning messages:

> chan_pjsip.c:1838 chan_pjsip_indicate: Don't know how to indicate condition 28

Is there a way to silence them or will I have to modify chan_pjsip for that?


File res/res_pjsip_t38.c:

https://gerrit.asterisk.org/c/asterisk/+/19460/comment/0d56085a_497de66d 
PS3, Line 583: 	if (!f || event != AST_FRAMEHOOK_EVENT_WRITE) {
> After I added my res_pjsip_aoc framehook, I was getting a segfault here in res_pjsip_t38. […]
Actually, please disregard. I had a "return 0" at the end of my framehook instead of a "return f". Fixed that and reverted change to res_pjsip_t38.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19460
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 29 Oct 2022 14:06:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Michael Kuron <m.kuron at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221029/374e65b7/attachment.html>