[Asterisk-code-review] res_pjsip_parameters: Add custom parameter support. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Alexei Gradinari, George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18830 )

Change subject: res_pjsip_parameters: Add custom parameter support.
......................................................................


Patch Set 7:

(4 comments)

This change is ready for review.

Patchset:

PS7: 
Thanks for the feedback, all. This has been much improved: both URI and header parameters are fully supported, as well as read/write, which is much more than the original patch did.


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18830/comment/98ec7a63_074ff06c 
PS1, Line 1703: 	/* Set URI (inside the <>, as opposed to header (outside the <>)) parameters, if requested.
              : 	 * This is often necessary for SS7 trunking over SIP. Most carriers require
              : 	 * that added parameters be URI parameters (as opposed to header parameters).
              : 	 *
              : 	 * other_param is how to add custom URI parameters to the header
              : 	 * XXX: header_param is for header parameters, but doesn't seem to work at the moment.
              : 	 *
              : 	 * Especially when dealing with SS7 or TDM elements over SIP,
              : 	 * injecting parameters into the user and/or method parameters
              : 	 * is required.
              : 	 *
              : 	 * For example, if wanted to set the isup-oli parameter to the channel's ANI2 value:
              : 	 * e.g. pjsip_param_add(dlg_pool, &dlg_info_uri->other_param, "isup-oli", ani2);
> <sip:foo at bar.com;p1=abc;p2=def?h1=qrs&h2=tuv>;o1=foo;o2=bar […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18830/comment/b33d6112_accb546d 
PS1, Line 1731: 	while ((param_value = strsep(&params, ","))) {
              : 			param_name = strsep(&param_value, "=");
> > Parameter names wouldn't contain equal signs, so I don't think the strsep on = is an issue. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18830/comment/f888ad83_efe84224 
PS1, Line 1734: 			pjsip_param_add(dlg_pool, &dlg_info_uri->other_param, param_name, S_OR(param_value, ""));
> Actually I think Asterisk already handles certain things such as the transport parameter and a coupl […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 11 Oct 2022 20:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221011/77deebce/attachment.html>