[Asterisk-code-review] say: Don't prepend ampersand erroneously. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19316 )

Change subject: say: Don't prepend ampersand erroneously.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File main/say.c:

https://gerrit.asterisk.org/c/asterisk/+/19316/comment/766d15bd_ac410e5a 
PS1, Line 163: 			ast_str_append(&filenames, 0, (outnum++ == 0 ? "%s" : "&%s"), fn);
ast_str_append(&filenames, 0, "%s%s", ast_str_strlen(filenames) ? "&" : "", fn);
 
Then you don't need the outnum variable at all. ast_str_strlen() is inlined and is just a field access, so it's cheap.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19316
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I02c1d3a11d82fe4ea8b462070cbd1effb5834d2b
Gerrit-Change-Number: 19316
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 16:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221006/328faae6/attachment.html>