[Asterisk-code-review] res_pjsip_outbound_registration: Allow to use multiple proxies for re... (asterisk[16])

[Joshua Colp]

Attention is currently required from: Igor Goncharovsky.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19202 )

Change subject: res_pjsip_outbound_registration: Allow to use multiple proxies for registration
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/19202/comment/ec6b499b_7b80d159 
PS2, Line 1407: 	pj_strdup2_with_null(pool, &tmp, registration->outbound_proxy);
This doesn't need to be done. This is copying the value of registration->outbound_proxy into tmp. The tmp variable is then never used (it was previously used for the URI parsing test). This should be removed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19202
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I064558e66f04b9f3260c46181812a01349761357
Gerrit-Change-Number: 19202
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 08:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221005/df8dde4f/attachment.html>