[Asterisk-code-review] audiohook: add directional awareness (asterisk[18])

[Joshua Colp]

Attention is currently required from: Michael Bradeen, N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19318 )

Change subject: audiohook: add directional awareness
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

File include/asterisk/audiohook.h:

https://gerrit.asterisk.org/c/asterisk/+/19318/comment/b4b32ebd_eb1458f9 
PS2, Line 146:  * \param direction In which direction should the audiohook feed frames
I think this needs further explanation of what it actually means with an example.


https://gerrit.asterisk.org/c/asterisk/+/19318/comment/88a4c6fb_9a83560b 
PS2, Line 150: int ast_audiohook_set_direction(struct ast_audiohook *audiohook, enum ast_audiohook_direction direction);
I think this API call could also be expanded to be more expressive of what it means. ast_audiohook_set_feed_direction?


File res/res_stasis_snoop.c:

https://gerrit.asterisk.org/c/asterisk/+/19318/comment/a8e7aaed_2b0a94f1 
PS2, Line 278: 	/* Set the audiohook direction so we don't write unnecissary frames */
unnecessary



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19318
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: If8716bad334562a5d812be4eeb2a92e4f3be28eb
Gerrit-Change-Number: 19318
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 03 Oct 2022 11:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221003/0344f922/attachment.html>