[Asterisk-code-review] app_voicemail_odbc: Fix string overflow warning. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19563 )

Change subject: app_voicemail_odbc: Fix string overflow warning.
......................................................................


Patch Set 2:

(2 comments)

File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/19563/comment/49771a95_920e3d6d 
PS1, Line 4492: 		ast_copy_string(fn, dir, sizeof(fn));
> GCC complains about negative offset, but do we understand why it's doing that? Is it actually possib […]
I don't see how it's possible, it could also be an issue with ast_copy_string itself since it doesn't happen with strncpy, snprintf, etc., but I didn't want to touch ast_copy_string.


https://gerrit.asterisk.org/c/asterisk/+/19563/comment/15fb8007_ed34957c 
PS1, Line 4485: 	char full_fn[PATH_MAX + 4];
> Why + 4?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19563
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8eecedf14d3f2a75864797f802277cac89a32877
Gerrit-Change-Number: 19563
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 29 Nov 2022 01:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221129/b8cc3aa9/attachment-0001.html>