[Asterisk-code-review] channel.c: Preserve tone playback on masquerades. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19572 )

Change subject: channel.c: Preserve tone playback on masquerades.
......................................................................


Patch Set 1:

(1 comment)

File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/19572/comment/98e0f653_729ce874 
PS1, Line 7154: 		 * then it makes sense to move the generator over.
> Have you gone through the history to understand why things were written this way in the first place? […]
This is the commit that introduced this regression: https://github.com/asterisk/asterisk/commit/37815b2cceb1b3cbbf4e18441dc4b542c897753e

Unfortunately, it was from 2006, when commit messages generally contained no information, and neither of the people involved is here anymore, so there's no context to me as to why this may have been done. Do you recall potentially?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4753d465bd4d5bb7fe205918e0f22b95a5e869e1
Gerrit-Change-Number: 19572
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 15:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/063d3a38/attachment-0001.html>