[Asterisk-code-review] core & res_pjsip: Improve topology change handling. (asterisk[18])

[Maximilian Fridrich]

Attention is currently required from: Joshua Colp.

Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19059 )

Change subject: core & res_pjsip: Improve topology change handling.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS2: 
> I've marked this +1, however this does currently have a merge conflict that will need to be resolved […]
Thank you very much for the review! As you know, we are working with topologies that contain multiple streams (audio+video) quite a lot and in many different scenarios. This probably won't be the last fix regarding multi-stream topologies (as it doesn't yet fix all of our use cases), however it is a step in the right direction.

I have a feeling that the resolve_refresh_media_states function can be further simplified for reasons I stated in the commit message. I will look into this more in the near future.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19059
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Icd0703295271089057717006730b555b9a1d4e5a
Gerrit-Change-Number: 19059
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 14:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/1c2e0e72/attachment.html>