[Asterisk-code-review] res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip (asterisk[20])

[Joshua Colp]

Attention is currently required from: Michael Kuron.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19532 )

Change subject: res_pjsip_aoc: New module for sending advice-of-charge with chan_pjsip
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File res/res_pjsip_aoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19532/comment/46c5f34e_0890efe9 
PS3, Line 183: 	pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "AOC", 2048, 512);
I'm surprised PJSIP isn't screaming at you for this, but this pool allocation has to be done inside of a PJSIP thread. It is TOLERANT of it generally but it will cause warnings/errors and can cause an assertion in developer mode.

Anything involving PJSIP needs to be queued up as a task to be done on one of the threads.

This is generally taken care of but because you're at the boundary between the core and PJSIP, it's not here so you have to do it yourself.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19532
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: Iebb7ad0d5f88526bc6629d3a1f9f11665434d333
Gerrit-Change-Number: 19532
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Kuron <m.kuron at gmx.de>
Gerrit-Comment-Date: Thu, 24 Nov 2022 10:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221124/7060ede9/attachment.html>