[Asterisk-code-review] res_adsi: Fix major regression caused by media format rearchitecture. (asterisk[master])

[N A]

N A has uploaded a new patch set (#3). ( https://gerrit.asterisk.org/c/asterisk/+/19576 )

Change subject: res_adsi: Fix major regression caused by media format rearchitecture.
......................................................................

res_adsi: Fix major regression caused by media format rearchitecture.

The commit that rearchitected media formats,
a2c912e9972c91973ea66902d217746133f96026 ASTERISK_23114)
introduced a regression by improperly translating code in res_adsi.c.
In particular, the pointer to the frame buffer was initialized
at the top of adsi_careful_send, rather than dynamically updating it
for each frame, as is required.

This resulted in the first frame being repeatedly sent,
rather than advancing through the frames.
This corrupted the transmission of the CAS to the CPE,
which meant that CPE would never respond with the DTMF acknowledgment,
effectively completely breaking ADSI functionality.

This issue is now fixed, and ADSI now works properly again.

ASTERISK-29793 #close

Change-Id: Icdeddf733eda2981c98712d1ac9cddc0db507dbe
---
M res/res_adsi.c
1 file changed, 31 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/76/19576/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19576
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icdeddf733eda2981c98712d1ac9cddc0db507dbe
Gerrit-Change-Number: 19576
Gerrit-PatchSet: 3
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-CC: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221123/35c85a77/attachment.html>