[Asterisk-code-review] xmldoc: Allow XML docs to be reloaded. (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19474 )

Change subject: xmldoc: Allow XML docs to be reloaded.
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

Patchset:

PS4: 
> Done - I've added notes where a user would encounter this, I've left the reload the same so xmldoc_r […]
Fair enough.


File main/config_options.c:

https://gerrit.asterisk.org/c/asterisk/+/19474/comment/5c4f9a93_3345b528 
PS5, Line 1102: 		ast_log(LOG_WARNING, "Cannot update type '%s' in module '%s' because it has no existing documentation!\n", name, module);
              : 		ast_log(LOG_WARNING, "If this module was recently built, run 'xmldoc reload' to refresh documentation, then load the module again\n");
Just combine these into one call to ast_log.  That way if there's a spew of messages (which there will likely be at startup), these two don't get separated.


File main/xmldoc.c:

https://gerrit.asterisk.org/c/asterisk/+/19474/comment/7c22ba5b_a8c3ce91 
PS5, Line 2219: 		ast_log(LOG_WARNING, "Couldn't find %s %s in XML documentation\n", type, name);
              : 		ast_log(LOG_WARNING, "If this module was recently built, run 'xmldoc reload' to refresh documentation\n");
              : 
Same.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19474
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4f265b0e5517e757c5453a0f241201a5788d3a07
Gerrit-Change-Number: 19474
Gerrit-PatchSet: 5
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 11 Nov 2022 12:24:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221111/fdaef069/attachment-0001.html>