[Asterisk-code-review] res_pjsip_header_funcs: Add custom parameter support. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Alexei Gradinari, Stanislav Abramenkov, George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18830 )

Change subject: res_pjsip_header_funcs: Add custom parameter support.
......................................................................


Patch Set 11:

(5 comments)

Patchset:

PS9: 
> I talked to Josh and he's OK with it going into res_pjsip_header_funcs as long as I agree to maintain it.

I would maintain it if there were issues either way, but core support is always nice :)

> At the time this function would be called, have we already finalized the contents of the From header?  I.E. has callerid been set along with any privacy requirements, has "from_domain" and "from_user" from the endpoint been applied?  Does order matter when calling this function along with the CALLERID function?

It should not matter, the add function adds them to the pool and PJSIP will generate the header when the INVITE is actually being sent.


File res/res_pjsip_parameters.c:

https://gerrit.asterisk.org/c/asterisk/+/18830/comment/5a0d4cd6_b0e23218 
PS9, Line 59: 			<parameter name="header_name" required="false">
            : 				<para>Header in which parameter should be read or set.</para>
            : 				<para>Currently, the only supported header is <literal>From</literal>.</para>
            : 			</parameter>
> Since you're implying that future headers may be supported, you should change this to "required". […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18830/comment/af6d5bd4_14bbf10f 
PS9, Line 89: static const struct ast_datastore_info param_datastore = {
            : 	.type = "param_datastore",
            : };
            : 
> Not seeing where this is used anymore.
Done


https://gerrit.asterisk.org/c/asterisk/+/18830/comment/7ebe127e_f9aaa1d5 
PS9, Line 172: 	dlg_info_uri = pjsip_uri_get_uri(dlg_info_name_addr);
> Are you absolutely sure this will be a sip/sips uri?
Done


https://gerrit.asterisk.org/c/asterisk/+/18830/comment/ba44df20_79ea516b 
PS9, Line 187: pjsip_param_add
> I know it's just a macro but can you rename this so it doesn't start with "pjsip_". […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 11
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 09 Nov 2022 14:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221109/aebe18fa/attachment-0001.html>