[Asterisk-code-review] res_pjsip: Fix double Route headers in OPTIONS (asterisk[16])

[George Joseph]

Attention is currently required from: Sean Bright, Igor Goncharovsky.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19211 )

Change subject: res_pjsip:  Fix double Route headers in OPTIONS
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/19211/comment/8fe8043a_4d1d98f8 
PS3, Line 1226: 	if (pjsip_method_cmp(method, &pjsip_options_method)) {
Is there an easy way to check if we've already added a Route header and if we have, simply skip adding another one?  This would keep the options-specific logic in pjsip_options.c instead of having the special case in the generic out-of-dialog function.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19211
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic43137cfcc468791bf4891ec9792bdb45043a5dc
Gerrit-Change-Number: 19211
Gerrit-PatchSet: 3
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Tue, 08 Nov 2022 13:07:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221108/ebf115a6/attachment.html>