[Asterisk-code-review] cli: Fix CLI blocking forever on terminating backslash (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18004 )

Change subject: cli: Fix CLI blocking forever on terminating backslash
......................................................................


Patch Set 3:

(1 comment)

File main/asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/18004/comment/8997078a_fdae70d9 
PS1, Line 2988: 			res = read(ast_consock, mbuf + mlen, 1024);
> Kinda torn on this. […]
The usage doesn't get printed. It gets into the buffer, but if we see that there, that's our signal to abort, since we know tab complete strings never start with "Usage:". Nothing gets printed to the CLI, so effectively it's a "no-op" to the user since nothing happens. It's a better match for the non remote console behavior.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18004
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9810ac59304fec162da701653c9c834f0ec8f670
Gerrit-Change-Number: 18004
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 31 May 2022 21:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/7a06867a/attachment.html>