[Asterisk-code-review] res_pjsip: allow TLS verification of wildcard cert-bearing servers (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Joshua Colp, N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18572 )

Change subject: res_pjsip: allow TLS verification of wildcard cert-bearing servers
......................................................................


Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18572/comment/3de8c470_2fcd4015 
PS2, Line 15: well as the common name that start with '*.' to match as a wildcard.
> Add "when verify_server is enabled".
Done


File res/res_pjsip/pjsip_transport_events.c:

https://gerrit.asterisk.org/c/asterisk/+/18572/comment/0c153d9f_4467004e 
PS2, Line 145: static void verify_log_result(int log_level, pj_uint32_t verify_status)
> When it comes to logging, can we include the transport name and remote address information?
Done


https://gerrit.asterisk.org/c/asterisk/+/18572/comment/4106dc2c_8ad43fe9 
PS2, Line 236: 	 * there was a name matching error it could because they disallow wildcards.
> could be because
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18572
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If0be3fdab2e09c2a66bb54824fca406ebaac3da4
Gerrit-Change-Number: 18572
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 31 May 2022 17:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/98844294/attachment.html>