[Asterisk-code-review] res_clioriginate: Add dialplan exec CLI command. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18561 )

Change subject: res_clioriginate: Add dialplan exec CLI command.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File res/res_clioriginate.c:

https://gerrit.asterisk.org/c/asterisk/+/18561/comment/e3173111_a15b6f04 
PS2, Line 232: static const struct ast_channel_tech mock_channel_tech = {
This CLI command should be in a separate module. I don't believe it belongs in here, as this module is for origination and some channel manipulation.

As well there is inconsistency between what you are calling the channel. Here you use a mock channel tech, in the documentation you call it a dummy channel, in error scenario you call it a bogus channel.


https://gerrit.asterisk.org/c/asterisk/+/18561/comment/c479a022_db76c343 
PS2, Line 250: 			"Usage: dialplan exec application <appname> [<args>]\n"
The codecs used should be documented here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18561
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I42e9fa9b60746c21450d40f99a026d48d2486dde
Gerrit-Change-Number: 18561
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 31 May 2022 10:37:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220531/9ab8fa7e/attachment-0001.html>