[Asterisk-code-review] res_pjsip_sdp_rtp: Send topology changed after hold/unhold. (asterisk[16])

[Joshua Colp]

Attention is currently required from: Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18571 )

Change subject: res_pjsip_sdp_rtp: Send topology changed after hold/unhold.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/18571/comment/bfa7e6f1_52103fcd 
PS1, Line 2106: 			 * a topoology_change update. Otherwise the hold indication could overwrite the
If the problem is on the other side, have you investigated that at all? From my brief looking at the code, I think the underlying issue is that remote_send_hold_refresh in chan_pjsip.c is applying locally_held to all streams, when in reality it should only apply to the default audio stream. All other streams should be left alone.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18571
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I04f1110565fd05fea565f5539b534b54549d4f71
Gerrit-Change-Number: 18571
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Thu, 26 May 2022 12:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220526/15c4a7f9/attachment.html>