[Asterisk-code-review] res_pjsip_outbound_registration: Make max random delay configurable. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18195 )

Change subject: res_pjsip_outbound_registration: Make max random delay configurable.
......................................................................


Patch Set 2:

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/eeab552a_fcb27f2f 
PS1, Line 14: This can create limitations with the test suite where we need to
> I don't understand this. […]
Done


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/2eb84a39_2274cd37 
PS1, Line 1345: ;max_random_delay=10    ; Maximum random delay for initial registrations (default: 10)
> Document why this behavior even exists, as you've done in the commit message, and the ramifications  […]
Done


File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18195/comment/484a921d_2496558b 
PS1, Line 112: 				<configOption name="max_random_delay" default="10">
> I'm not sure what your question is. […]
Ah, gotcha. Thanks for steering me in the right direction.


https://gerrit.asterisk.org/c/asterisk/+/18195/comment/8c75f8f2_c09ffc23 
PS1, Line 1743: 	max_delay = registration->max_random_delay;
> Okay, so there isn't a reason beyond making the code look a little cleaner. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iab989a8e94323e645f3a21cbb6082287c7b2f3fd
Gerrit-Change-Number: 18195
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 18 May 2022 17:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220518/f6fdf928/attachment.html>