[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 3:

(4 comments)

Patchset:

PS2: 
> There were multiple files involved in that issue. The app_dial bit is here: https://gerrit.asterisk. […]
Ack


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/75d6963b_510923a5 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
> Ah, I see. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/18521/comment/59517942_06e9045c 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
> Ah, I see. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/18521/comment/38fae9b7_fb753ba4 
PS2, Line 2845: 	if (!valid_peers) {
> Heh, good point. I'll update it to that.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Sat, 14 May 2022 13:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220514/5ed17c21/attachment.html>