[Asterisk-code-review] res_agi: Evaluate dialplan functions and variables in agi exec (asterisk[19])

Shloime Rosenblum asteriskteam at digium.com
Thu May 12 12:31:02 CDT 2022


Attention is currently required from: Sean Bright, Joshua Colp, N A.
Shloime Rosenblum has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18537 )

Change subject: res_agi: Evaluate dialplan functions and variables in agi exec
......................................................................


Patch Set 7:

(1 comment)

Patchset:

PS7: 
> To elaborate further - we try extremely hard to not change behavior if it can be helped, since we do […]
Can you describe a scenario where it will break existing behavior? Until now you would need to get the variable and add it to the data but there is no use of the variable/function format (${})



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18537
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: I669991f540496e7bddd096fec82b52c083036832
Gerrit-Change-Number: 18537
Gerrit-PatchSet: 7
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 12 May 2022 17:31:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220512/714fb2aa/attachment.html>


More information about the asterisk-code-review mailing list