[Asterisk-code-review] crypto: Don't load non-regular files in keys directory (asterisk[master])

[Philip Prindeville]

Attention is currently required from: George Joseph.
Philip Prindeville has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18533 )

Change subject: crypto: Don't load non-regular files in keys directory
......................................................................


Patch Set 5:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18533/comment/6cdc136b_cae04717 
PS5, Line 7: crypto
> Use the full module name when possible. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18533/comment/fedf5019_b9fbae0b 
PS5, Line 11: Signed-off-by: Philip Prindeville <philipp at redfish-solutions.com>
> We don't use "signed-off-by".  It should be removed.
Done


File res/res_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18533/comment/a97d2228_e44a5f27 
PS5, Line 519: 				continue;
> I'd add a WARNING here that the entry wasn't a regular file.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18533
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie77e0648f8b0b1c2159fb24662d1989cfd4cc36d
Gerrit-Change-Number: 18533
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 May 2022 15:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/c62f6383/attachment.html>