[Asterisk-code-review] app_dial: Fix dial status regression. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18521 )

Change subject: app_dial: Fix dial status regression.
......................................................................


Patch Set 2:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/18521/comment/487402ad_3876cd13 
PS2, Line 2705: 			ast_log(LOG_NOTICE, "Unable to create channel of type '%s' (cause %d - %s)\n",
> I also disagree with changing this, and I'd rather err on the side of warning here - because this is […]
Sure, but isn't that what "NOTICE" is for, exactly? "NOTICE" means "something happened". "WARNING" means "something bad happened".

A called B and B was on the phone so A got a busy signal is not valid cause for throwing a WARNING. There is *nothing* "wrong" with this in any way.

At the very least, busy should NOT throw a warning, even if other dispositions like unavailable do. That seems like a reasonable compromise, thoughts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18521
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4d4b209b967816b1bc791534593ababa2b99bb88
Gerrit-Change-Number: 18521
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 May 2022 12:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220509/0384d05a/attachment.html>