[Asterisk-code-review] GCC12: Fixes for 16+ (asterisk[16])

[Kevin Harwell]

Attention is currently required from: George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18529 )

Change subject: GCC12: Fixes for 16+
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

File apps/app_festival.c:

https://gerrit.asterisk.org/c/asterisk/+/18529/comment/92c6feb5_68628889 
PS1, Line 436: 	if (strlen(cachedir) + sizeof(MD5Hex) + 1 <= MAXFESTLEN && (usecache == -1)) {
> > For 1) I'm saying strlen(x) will always be at least one less (possibly more) than sizeof(x). […]
I was thinking there is possibly a runtime change (not compile time) here, but if MD5Hex is always 32 bytes then it shouldn't ever be a problem.


File include/asterisk/strings.h:

https://gerrit.asterisk.org/c/asterisk/+/18529/comment/c1097ca6_3e881420 
PS1, Line 396: 	volatile size_t sz = size;
             : 	volatile char *sp = (char *)src;
> Not sure tbh. Here's how I understand it though. […]
okay ya my thinking is wrong.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18529
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia081ca1bcfb329df6487c4660aaf1944309eb570
Gerrit-Change-Number: 18529
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 05 May 2022 15:46:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220505/926bf380/attachment.html>