[Asterisk-code-review] cli: Prevent assertions on startup from bad ao2 refs. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18523 )

Change subject: cli: Prevent assertions on startup from bad ao2 refs.
......................................................................


Patch Set 1:

(1 comment)

File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/18523/comment/de62abb9_cff61960 
PS1, Line 1143: 	while (!ast_test_flag(&ast_options, AST_OPT_FLAG_FULLY_BOOTED)) {
> > What is not fully initialized? […]
I don't see what the channel drivers have to do with anything regarding a core channels container. It should be initialized before they're even loaded, already, and in fact it is.

CLI commands should not be registered until everything they rely on (such as a container) is initialized. The issue is that all the built-in CLI commands are registered before things are initialized currently, including channels. It could even potentially impact other CLI commands.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b3cde802876bd738c1b4cf2683bea6ddc615b6
Gerrit-Change-Number: 18523
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 03 May 2022 13:18:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220503/f34ef398/attachment.html>