[Asterisk-code-review] pbx.c: Warn if there are too many includes in a context. (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Michael Bradeen, N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18223 )

Change subject: pbx.c: Warn if there are too many includes in a context.
......................................................................


Patch Set 1:

(1 comment)

File main/pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/18223/comment/413ee636_0fdeb1d5 
PS1, Line 8781: 	for (idx = 0; idx < includecount; idx++) {
> Should we stop this at AST_PBX_MAX_STACK?
I don't think checking for it would matter here. "includecount" should always be less than or equal to AST_PBX_MAX_STACK so this loop should always stop before max is hit.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18223
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia3700452e75a7af3391b3e82ee69f06a669f8958
Gerrit-Change-Number: 18223
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 23:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220323/c41864b8/attachment-0001.html>