[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File configs/samples/features.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/0ffb8d5f_94dc43ba 
PS3, Line 10:                                 ; TRANSFER_EXTEN variable has been set on the channel.
This doesn't actually state what TRANSFER_EXTEN actually does, a user has to infer it based on the name. The statement should be clearer. "If the TRANSFER_EXTEN dialplan variable is set this option is not used and instead the user is transferred to the extension specified by the dialplan variable."

As well, on what channel should it be set? Is context supported? What context is used?

You have to be very specific. You may know this, but an average user doesn't and they can't/won't look at the code.


File doc/CHANGES-staging/transfer.txt:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/e5312cae_2e7cd8b9 
PS3, Line 12: variable, if it exists.
My comment on the sample config applies here too. What channel should this variable be set on? The transferer or the transferee? Is context supported? What context is used?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 12:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220310/0e5bae85/attachment.html>