[Asterisk-code-review] res_geolocation: eprofile, parsing, tests and more (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: Joshua Colp.
Hello Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/18127

to look at the new patch set (#4).

Change subject: res_geolocation: eprofile, parsing, tests and more
......................................................................

res_geolocation: eprofile, parsing, tests and more

There's a lot of stuff in this commit so hold on to
your knickers.

* Added ability to embed xml and xslt documents into a module.
  It's actually quite simnple and works for gcc and clang.
  See Makefile.rules, res/Makefile and geoloc_eprofile for
  more info.

* Fixed an issue with ast_variable_list_from_string where
  quotes weren't being handled correctly.  This required
  the addition of ast_strsep_strict() to utils.c

* Renamed some things...
   pidf_lo_section was renamed to just pidf_element.
   The "effective_profile" API names were shortened to
   "eprofile".

* Added a ast_xml_find_child_element() convenience macro.

* Added pidf_to_eprofile.xslt that condenses pidf-lo xml
  documents to a simpler format that's common to both GML
  and civicAddress formats.  This cut quite a bit of custom
  parsing code.

* Effective profiles can now be created directly from a pidf
  xml document or a URI.

* Created unit tests for effective profile creation.

Change-Id: I50b66bd041b2a62ab329406f20dbaeef1fa68fc1
---
M Makefile.rules
M configs/samples/geolocation.conf.sample
M include/asterisk/config.h
M include/asterisk/res_geolocation.h
M include/asterisk/strings.h
M include/asterisk/xml.h
M main/config.c
M main/utils.c
M res/Makefile
M res/res_geolocation.c
M res/res_geolocation/geoloc_channel.c
A res/res_geolocation/geoloc_common.c
M res/res_geolocation/geoloc_config.c
M res/res_geolocation/geoloc_doc.xml
A res/res_geolocation/geoloc_eprofile.c
M res/res_geolocation/geoloc_private.h
A res/res_geolocation/pidf_lo_test.xml
A res/res_geolocation/pidf_to_eprofile.xslt
M tests/test_config.c
19 files changed, 1,241 insertions(+), 132 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/27/18127/4
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18127
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I50b66bd041b2a62ab329406f20dbaeef1fa68fc1
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220309/cd9b2be1/attachment-0001.html>