[Asterisk-code-review] chan_pjsip: Add ability to send flash events. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18079 )

Change subject: chan_pjsip: Add ability to send flash events.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18079/comment/517fb289_e7bd3ce7 
PS2, Line 1707: 			ao2_cleanup(dtmf_data);
This warning message should include the channel name as well as endpoint name. As well, it's impossible for dtmf_data to be non-NULL so ao2_ref can be used instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18079
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1590221a4d238597f79672fa5825dd4a920c94dd
Gerrit-Change-Number: 18079
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 13:38:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220301/c486f9a6/attachment.html>