[Asterisk-code-review] testsuite: Python 3 compatibility inital commit (testsuite[development/16/python3])

[Michael Bradeen]

Attention is currently required from: Joshua Colp, George Joseph.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18528 )

Change subject: testsuite: Python 3 compatibility inital commit
......................................................................


Patch Set 13:

(7 comments)

Commit Message:

https://gerrit.asterisk.org/c/testsuite/+/18528/comment/27bb5831_da03a9cf 
PS12, Line 9: Multiple changes for compatibility.  Requires latest version of all
> This commit message needs a clean up as it's actually two meshed together.
Done


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/testsuite/+/18528/comment/39402e21_27be5412 
PS12, Line 269: 	echo "Testsuite requires python version >= 3.8"
> Should this be 3.6. […]
Done


File lib/python/asterisk/extension_bank.py:

https://gerrit.asterisk.org/c/testsuite/+/18528/comment/28121349_384b5ad2 
PS12, Line 2: Copyright (C) 2022, Sangoma Corp
> Sangoma Technologies Corporation
Done


File lib/python/asterisk/pcap.py:

https://gerrit.asterisk.org/c/testsuite/+/18528/comment/a8ed0b02_cbdf7667 
PS12, Line 712:         #interpreted_packet = self._packet_factories.SIPPacketFactory.interpret_packet(packet)
> Should this just be removed? Is it no longer needed?
commit error.


File runtests.py:

https://gerrit.asterisk.org/c/testsuite/+/18528/comment/9a209de5_f5441162 
PS12, Line 72: #ast_config = test_suite_utils.get_asterisk_conf()
> What's the story of the change here?
runtests was aggressively looking for pjsua which would cause it to immediately fail. No need to look for a module we have no intention of using.
Removed commented out section.


File tests/rest_api/chunked-transfer/run-test:

https://gerrit.asterisk.org/c/testsuite/+/18528/comment/bac4302b_9fcea9e9 
PS12, Line 35: 
> Can be removed
Done


https://gerrit.asterisk.org/c/testsuite/+/18528/comment/194f39f1_fa8e9a4e 
PS12, Line 67: #                data=bytes(chunkizer(b"{ b'variable': b'foo', b'value': b'bar'' }"),"utf-8"),
> Can be removed
Done



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18528
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: development/16/python3
Gerrit-Change-Id: I55caad3cb2a156b8e3f2f24dd10db5ebe67910d2
Gerrit-Change-Number: 18528
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220622/0d59b662/attachment.html>