[Asterisk-code-review] chan_iax2: permit frames without voice format. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: Sean Bright.
Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18689 )

Change subject: chan_iax2: permit frames without voice format.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> > This fixes my immediate issue […]
Lack of indications.

So basically we have a SIP endpoint on one side, that goes via an IAX/2 channel and then to SIP again, basically:

d1 <= SIP => [ a1 ] <= IAX/2 => [ a2 ] <= SIP => d2

Now, d1 sends initial INVITE, gets it's 100 Trying, after IAX/2 does it's magic, a2 sends invite to d2, gets 100 Trying, and 180 Ringing.

At this point a2 generates RINGING indication (without media) back to a1, which then proceeds to DROP this indication because there is no supported media associated.  This ends up so that d1 never hears ringing unless somewhere along the chain we're generating early media.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18689
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I80f9c1af4b2cd8281dbd74cb7cbc01b8deccdf96
Gerrit-Change-Number: 18689
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 15:24:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220727/fb61cc66/attachment-0001.html>