[Asterisk-code-review] test: Add coverage for res_crypto (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18532 )

Change subject: test: Add coverage for res_crypto
......................................................................


Patch Set 18: Code-Review-1

(3 comments)

File include/asterisk/crypto.h:

https://gerrit.asterisk.org/c/asterisk/+/18532/comment/b59183c9_7ad8b05d 
PS18, Line 42: #define AST_CRYPTO_RSA_KEY_BITS		1024
Document where these originate from/why.


https://gerrit.asterisk.org/c/asterisk/+/18532/comment/48083d37_095f3064 
PS18, Line 186: AST_OPTIONAL_API(int, ast_crypto_reload, (void), { return 0; });
Support for reload shouldn't be done as part of adding test coverage, this should be in a separate commit even though it is small.


File tests/test_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18532/comment/159c1699_dce21960 
PS18, Line 90: 	const char *path = "openssl";
The test should verify that the openssl application is actually available.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18532
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0d10e7b41009c5290a4356c6480e636712d5c96d
Gerrit-Change-Number: 18532
Gerrit-PatchSet: 18
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 15:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/79fce1c2/attachment.html>