[Asterisk-code-review] res_pjsip_session: Add custom parameter support. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Alexei Gradinari, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18830 )

Change subject: res_pjsip_session: Add custom parameter support.
......................................................................


Patch Set 1:

(2 comments)

File doc/CHANGES-staging/res_pjsip_session_params.txt:

https://gerrit.asterisk.org/c/asterisk/+/18830/comment/554bcd34_bedec02d 
PS1, Line 5: SIPURIPARAMETERS variable on a channel
> Although inherently it is kind of like PJSIP_HEADER as mentioned, so maybe it does make sense.
I guess that would mean no variable under the hood either, the way that chan_sip does it for instance like with Set(SIP_HEADER(... ?
For example, right now you need to add a single underscore (at least) since it will only pick up the variable on the outgoing channel itself, not the Dial channel.


https://gerrit.asterisk.org/c/asterisk/+/18830/comment/4bc3c849_adf3d91a 
PS1, Line 5: SIPURIPARAMETERS variable on a channel
> Although inherently it is kind of like PJSIP_HEADER as mentioned, so maybe it does make sense.
The difference between this and PJSIP_HEADER is that each individual header as its own semantics in pjproject (e.g. there is a structure just for the From header IIRC). You really need to handle each possible header separately. So if there's going to be a generic function to set/get parameters on any arbitrary header, it will most certainly be incomplete.

I'm thinking it should either be limited to headers that make sense or just From, or otherwise it might be suboptimal for other headers.

FWIW, from what I've seen about usage of these custom parameters, I've never seen them in any header besides the From header (as far as setting them).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 02:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220725/7ec11dbf/attachment.html>