[Asterisk-code-review] res_pjsip_session: Add custom parameter support. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Alexei Gradinari, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18830 )

Change subject: res_pjsip_session: Add custom parameter support.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File doc/CHANGES-staging/res_pjsip_session_params.txt:

https://gerrit.asterisk.org/c/asterisk/+/18830/comment/0c63578c_bfde933a 
PS1, Line 5: SIPURIPARAMETERS variable on a channel
> I thought that in PJSIP we are moving away from using channel variables in favor of functions. […]
I had thought SIPURIPARAMETERS was one of the existing channel variables in use by chan_sip, which we have allowed before for compatibility but it is a new one. A dialplan function would therefore be better.

I think there's no need for specifying set or read, since the dialplan function inherently provides that difference.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18830
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1bc3c512ad5f6faeaebd7817f004a2ecbd6428
Gerrit-Change-Number: 18830
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 23:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220725/249c85b3/attachment-0001.html>