[Asterisk-code-review] revert deleted files that create 10000 lines of change (asterisk[master])

[Alec Davis]

Attention is currently required from: Joshua Colp, N A.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: revert deleted files that create 10000 lines of change
......................................................................


Patch Set 4:

(10 comments)

Patchset:

PS4: 
Thanks Josh

Now to work through Sean's comments.


File configs/samples/redisd.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/547699c5_47587d71 
PS4, Line 2: enabled = yes			; When set to yes, redisd support is enabled
> What's the default?
Done


File include/asterisk/redisd.h:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/e4fb9f7d_979198e4 
PS4, Line 30: AST_OPTIONAL_API(void, ast_redisd_command, (const char *command, const char *key_path, const char *_keyvalue, char *return_buffer, size_t return_buffwe_len), {});
> This needs to be documented
Done


File res/res_redis_device_state.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/27fbd6df_74eed094 
PS4, Line 49: 	char return_buffer[4096];
> Why 4096?
Done


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/934a2746_95a79054 
PS4, Line 69: 		ast_debug(6, "device length zero\n");
> Is it possible for this to happen?
Being too cautious, I guess not.


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c57c4f19_963006e8 
PS4, Line 78: 	ast_str_set(&key_path, 0, "deviceState:%s", device);
> This is easy to calculate as a fixed length, which means ast_str_alloca could be used instead of mal […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/75e2cdce_7c129b33 
PS4, Line 96: 	device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);
> This can fail
Done


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/9b4406d7_d00348d2 
PS4, Line 97: 
> Filtering was added for stasis subscriptions to reduce the work done within dispatching, this is don […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/383a8973_6757adc2 
PS4, Line 101: AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_GLOBAL_SYMBOLS | AST_MODFLAG_LOAD_ORDER, "REDIS Device State support",
> Why does this export global symbols?
Done


File res/res_redisd.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/7d191a06_ca538bb1 
PS4, Line 244: 		
> remove redness, done in next commit
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 4
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 23 Jul 2022 23:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alec Davis <alec at bdt.co.nz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220723/c6256fb0/attachment.html>